Conversation
Contributor
|
오 코드, 흐름, 훔쳐가겠습니다. |
nahyeongjin1
force-pushed
the
feature/save-api-key
branch
from
4f2b511 to
0e99654
Compare
apaals2
reviewed
Aug 5, 2025
nahyeongjin1
force-pushed
the
feature/save-api-key
branch
from
0e99654 to
4fb428a
Compare
Contributor
ChoiSeungWoo98
left a comment
ChoiSeungWoo98
left a comment
There was a problem hiding this comment.
작업은 비슷하게 됐을 거 같아서 일단 하나의 PR에만 리뷰 남기겠습니다!
Contributor
There was a problem hiding this comment.
각 기능별 코드 번호는 빠르게 회의 후 맞추면 좋을 거 같습니다!
nahyeongjin1
force-pushed
the
feature/save-api-key
branch
from
26afb3f to
f69b4a2
Compare
nahyeongjin1
force-pushed
the
feature/save-api-key
branch
2 times, most recently
from
bd4f07b to
00c03f8
Compare
nahyeongjin1
force-pushed
the
feature/save-api-key
branch
from
00c03f8 to
492ab25
Compare
Contributor
There was a problem hiding this comment.
값 유효성 검사는 어제 어노테이션이 아닌 직접 메서드 만들어서 관리하자고 되었던 거 같은데 확인 부탁드립니다.
Member
Author
There was a problem hiding this comment.
delete 브랜치 쪽에서 일괄적으로 하려고 했었는데 일단 pr 열려있는 브랜치에 다 변경을 해둘까요?
Contributor
|
수고하셨습니다 ~ !! |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[기능] API_KEY 저장